Skip to content

fix(deps): Bump @vercel/client and patch picomatch ReDoS - #982

Merged
BYK merged 2 commits into
masterfrom
fix/deps-zod-picomatch-advisories
Nov 18, 2026
Merged

BYK merged 2 commits into
masterfrom
fix/deps-zod-picomatch-advisories

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Fixes the two high advisories in the root and docs/ lockfiles.

GHSA-mrhx-c7xc-m3w5 (zod < 4.6.6), root. zod 3 came only from @vercel/client > @vercel/build-utils@14 > @vercel/python-analysis. @vercel/client@^18.12.3 uses @vercel/build-utils@15.4.2, which no longer depends on python-analysis, so zod drops out of the tree. A zod override would force zod 4 onto zod 3 code. The createDeployment API that the vercel target uses has not changed.

GHSA-fc5q-39xc-vjpf (picomatch ReDoS), root and docs. There is no fixed release. Following the braces precedent, this adds local pnpm patches for both installed versions, 4.0.7 and 2.3.2. 2.3.2 has the same bug. The advisory links micromatch/picomatch#194, but that PR covers ?-leading extglobs and does not fix +(*a). The patches backport micromatch/picomatch#267 (#268 for 2.x):

  • A single wildcard branch made of literals, ?, *, and bracket classes that cannot match / absorbs its own repetition. +(P) compiles as (P) and *(P) as (P)?, and the matches stay the same.
  • Other single-branch wildcard bodies are literalized, like the existing risky-extglob guard.

The patch differs from upstream in one place. Upstream would collapse a bracket range like [+-0], which includes /, and that changes what it matches. The patch checks each compiled bracket class first. Details are in patches/README.md.

After merge: Dependabot matches on version, so it will keep flagging the patched picomatch 4.0.7 and 2.3.2, as it already does for braces. Dismiss those alerts by hand.

Not covered: repeated extglobs with several branches that contain *, such as +(*a|b). That is the general upstream issue micromatch/picomatch#175. Literalizing them would break globs like +(*.js|*.ts).

via @BYK.

--

View Session [Sentry]

Bump @vercel/client to ^18.12.3. Its @vercel/build-utils no longer pulls in
@vercel/python-analysis, which removes zod 3 from the tree
(GHSA-mrhx-c7xc-m3w5).

picomatch has no fixed release for GHSA-fc5q-39xc-vjpf. Backport the open
upstream fix (micromatch/picomatch#267, #268 for 2.x) as pnpm patches for
the installed 4.0.7 and 2.3.2, in root and docs. Also check compiled bracket
classes so a range such as [+-0], which includes /, is not collapsed.

Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-11-18 11:44 UTC

@sentry-junior
sentry-junior Bot marked this pull request as ready for review November 18, 2026 11:31
@sentry-junior
sentry-junior Bot requested a review from BYK November 18, 2026 11:31
@BYK
BYK enabled auto-merge (squash) November 18, 2026 11:34

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a25c2a6. Configure here.

Comment thread patches/picomatch@4.0.7.patch Resolved
Comment thread patches/picomatch@4.0.7.patch Resolved
@BYK
BYK merged commit 635ac47 into master Nov 18, 2026
29 checks passed
@BYK
BYK deleted the fix/deps-zod-picomatch-advisories branch November 18, 2026 11:43
BYK pushed a commit that referenced this pull request Nov 18, 2026
…#983)

The local picomatch patches from #982 for
[GHSA-fc5q-39xc-vjpf](GHSA-fc5q-39xc-vjpf)
keep the repetition of any single-branch extglob with a literal `/`.
They assume the slash fixes where each repeat starts. Two shapes break
that and still backtrack exponentially:

- `+(**/a)`: a globstar crosses `/`.
- `+(*/*)`: one repeat's trailing `*` and the next repeat's leading `*`
share a path segment, so every segment can split two ways.

Now a slash body keeps its repetition only when it has no globstar and
every path segment holds at most one `*`, counting the segment shared
across repeats. Globs like `+(src/*/)` and `+(src/*/*.js)` match as
before. `+(**/a)`, `+(*/*)` and `+(*a/*)` are literalized, like the
other risky extglobs. The change covers the 4.0.7 and 2.3.2 patches in
root and `docs/`.

<!-- junior-request-attribution:start -->
via @BYK.
<!-- junior-request-attribution:end -->

<!-- junior-session-footer:start -->
<!-- junior-conversation-id:agent%3Aa3f271eaa645c4e79ce41158088ba41e -->

--

[View
Session](https://junior-prod.sentry.dev/conversations/agent%3Aa3f271eaa645c4e79ce41158088ba41e)
[[Sentry]](https://sentry.sentry.io/explore/conversations/agent%3Aa3f271eaa645c4e79ce41158088ba41e/?project=4510944073809921)

<!-- junior-session-footer:end -->

Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant